Skip to content

fix(go): fix go dockerfile build issues#182

Merged
codyoss merged 4 commits intogoogleapis:mainfrom
cojenco:upgrade-openssl
Dec 3, 2021
Merged

fix(go): fix go dockerfile build issues#182
codyoss merged 4 commits intogoogleapis:mainfrom
cojenco:upgrade-openssl

Conversation

@cojenco
Copy link
Copy Markdown
Contributor

@cojenco cojenco commented Dec 2, 2021 •
edited
Loading

Fix go dockerfile build issues (1)(2)

  • update python-openssl to python3-openssl in go116
  • revise go113, go114, go115 dockerfile commands
Reading package lists...
Building dependency tree...
Reading state information...
E: Unable to locate package python-openssl

go: cannot use path@version syntax in GOPATH mode
The command '/bin/sh -c GO111MODULE=on go get honnef.co/go/tools/cmd/staticcheck@latest &&     go get github.com/jstemmer/go-junit-report@latest' returned a non-zero code: 1

@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Dec 2, 2021
@cojenco cojenco requested a review from codyoss December 2, 2021 19:42
@cojenco cojenco changed the title fix(go): fix go116 Dockerfile build issue fix(go): fix go dockerfile build issues Dec 3, 2021
@cojenco cojenco marked this pull request as ready for review December 3, 2021 04:35
@cojenco cojenco requested a review from a team December 3, 2021 04:35
codyoss
codyoss approved these changes Dec 3, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@codyoss codyoss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tritone
tritone approved these changes Dec 3, 2021
View reviewed changes
Copy link
Copy Markdown

@tritone tritone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks v much Cathy!

@codyoss codyoss merged commit cab90fb into googleapis:main Dec 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@codyoss codyoss codyoss approved these changes

+1 more reviewer

@tritone tritone tritone approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@cojenco @tritone @codyoss