Upgrade to Suport AngularFire 2.0.1 and Firebase 3.0#68
Upgrade to Suport AngularFire 2.0.1 and Firebase 3.0#68matheushf wants to merge 17 commits intogooglearchive:masterfrom
Conversation
| if (!this.options.coffee && | ||
| this.expandFiles(path.join(this.appPath, '/scripts/**/*.coffee'), {}).length > 0) { | ||
| this.options.coffee = true; | ||
| } |
There was a problem hiding this comment.
If coffeescript isn't supported, let's go ahead and throw an error?
|
@matheushf thanks for this. Great work! I had one comment regarding CoffeeScript. Note that this PR looks to include a pretty serious rider: it restyles a lot of the code, creating a lot of diff fodder that is superfluous to the changes and unrelated to upgrading us to the latest. If we're going to change coding styles, then a) they should pass Angular linting styles and b) that should be done as a separate PR and consistently across the entire project. I know that's an annoyance, and it will be a bit of a mess to clean up. However, inversely, it will be a mess to have conflicting styles in the code and to clean it up after a PR as well. So I'm going to hold this until the formatting changes are removed and this is PR is focused on exactly one mission. |
|
Dude - thanks you two guys for being champs at this; @matheushf for initiative, git-r-done-ness, and hanging in there, and @katowulf for the project itself and for high levels of git&PR sophisitication (which I would have never thought of!) |
|
Alright @katowulf, I'm going to clean up the code. Actually, at the end I didn't notice that I had changed so much. And thanks @danieljsj 😄 |
|
Let me know when you're ready for me to test this out. |
|
is it possible to get the generator ?? |
4 participants
Still needs to update the CoffeeScript part, but the generator is fully working.
Issue #67