Fix .bazelrc to be compatible with Bazel 0.23.0#1
Closed
philwo wants to merge 1 commit intogooglecloudrobotics:masterfrom
philwo:patch-1
Closed
Fix .bazelrc to be compatible with Bazel 0.23.0#1philwo wants to merge 1 commit intogooglecloudrobotics:masterfrom philwo:patch-1
philwo wants to merge 1 commit intogooglecloudrobotics:masterfrom
philwo:patch-1
Conversation
The two flags --incompatible_remove_native_http_archive and --incompatible_remove_native_git_repository have been enabled by default in a recent release and were subsequently removed, so specifying them in Bazel 0.23.0 will result in an error due to the flags being unknown. We can just remove them from the .bazelrc now.
Author
|
FYI @ensonic |
Contributor
Do you remember which one, so that we can tell people to use e.g. >=0.20.0 |
Author
|
Yes, according to our issue tracker and release notes, the flags were flipped in 0.20.0: bazelbuild/bazel#6569 However, AFAIK it shouldn't really matter - By the way, not sure if it's interesting for you, but https://github.com/philwo/bazelisk is a helpful wrapper for Bazel, if you often have people building your project who might not have (the correct version of) Bazel installed. You can check it into your repo together with a |
|
We do not recommend running production builds with |
drigz
added a commit
that referenced
this pull request
Jul 22, 2025
This exports a list of connected PCI devices, so that we can track which GPUs and NICs are installed on the fleet. node-exporter doesn't support anything quite like this, the ethtool metric doesn't handle NICs that aren't bound to a kernel driver for example, nor can it identify the attached GPU. The new binary is 9MB, and the new process has 21MB RSS, which seems to mostly be TLS/protobuf dependencies that I guess come in via the OpenCensus libraries, but could also come in via the PCI library, as that has the ability to fetch a PCI ID database from the internet if enabled at runtime (it is not enabled in this binary). The extra metric load should be offset by #549. Example metrics: ``` # HELP pci_device_count Number of PCI devices by vendor, product, class, and driver. # TYPE pci_device_count gauge pci_device_count{class="Bridge",driver="",product="0x7a90",vendor="Intel Corporation"} 1 pci_device_count{class="Bridge",driver="",product="0xa700",vendor="Intel Corporation"} 1 pci_device_count{class="Bridge",driver="pcieport",product="0x7ab6",vendor="Intel Corporation"} 1 pci_device_count{class="Bridge",driver="pcieport",product="Alder Lake-S PCH PCI Express Root Port #13",vendor="Intel Corporation"} 1 pci_device_count{class="Bridge",driver="pcieport",product="Alder Lake-S PCH PCI Express Root Port #8",vendor="Intel Corporation"} 1 pci_device_count{class="Bridge",driver="pcieport",product="Raptor Lake PCI Express 5.0 Graphics Port (PEG010)",vendor="Intel Corporation"} 1 pci_device_count{class="Bridge",driver="pcieport",product="Raptor Lake PCIe 4.0 Graphics Port",vendor="Intel Corporation"} 1 pci_device_count{class="Communication controller",driver="",product="Alder Lake-S PCH Serial IO UART #0",vendor="Intel Corporation"} 1 pci_device_count{class="Communication controller",driver="mei_me",product="Alder Lake-S PCH HECI Controller #1",vendor="Intel Corporation"} 1 pci_device_count{class="Display controller",driver="nvidia",product="GA104GL [RTX A4000]",vendor="NVIDIA Corporation"} 1 pci_device_count{class="Mass storage controller",driver="ahci",product="Alder Lake-S PCH SATA Controller [AHCI Mode]",vendor="Intel Corporation"} 1 pci_device_count{class="Mass storage controller",driver="nvme",product="IX SN530 NVMe SSD (DRAM-less)",vendor="Sandisk Corp"} 3 pci_device_count{class="Memory controller",driver="",product="Alder Lake-S PCH Shared SRAM",vendor="Intel Corporation"} 1 pci_device_count{class="Multimedia controller",driver="",product="Alder Lake-S HD Audio Controller",vendor="Intel Corporation"} 1 pci_device_count{class="Multimedia controller",driver="",product="GA104 High Definition Audio Controller",vendor="NVIDIA Corporation"} 1 pci_device_count{class="Network controller",driver="atemsys_pci",product="Ethernet Connection (17) I219-LM",vendor="Intel Corporation"} 1 pci_device_count{class="Network controller",driver="igb",product="I210 Gigabit Network Connection",vendor="Intel Corporation"} 1 pci_device_count{class="Network controller",driver="intel-eth-pci",product="0x7aac",vendor="Intel Corporation"} 1 pci_device_count{class="Network controller",driver="intel-eth-pci",product="0x7aad",vendor="Intel Corporation"} 1 pci_device_count{class="Serial bus controller",driver="",product="Alder Lake-S PCH SPI Controller",vendor="Intel Corporation"} 1 pci_device_count{class="Serial bus controller",driver="",product="Alder Lake-S PCH Serial IO I2C Controller #0",vendor="Intel Corporation"} 1 pci_device_count{class="Serial bus controller",driver="",product="Alder Lake-S PCH Serial IO I2C Controller #1",vendor="Intel Corporation"} 1 pci_device_count{class="Serial bus controller",driver="",product="Alder Lake-S PCH Serial IO I2C Controller #2",vendor="Intel Corporation"} 1 pci_device_count{class="Serial bus controller",driver="",product="Alder Lake-S PCH Serial IO I2C Controller #3",vendor="Intel Corporation"} 1 pci_device_count{class="Serial bus controller",driver="",product="Alder Lake-S PCH Serial IO SPI Controller #1",vendor="Intel Corporation"} 1 pci_device_count{class="Serial bus controller",driver="i801_smbus",product="Alder Lake-S PCH SMBus Controller",vendor="Intel Corporation"} 1 pci_device_count{class="Serial bus controller",driver="xhci_hcd",product="Alder Lake-S PCH USB 3.2 Gen 2x2 XHCI Controller",vendor="Intel Corporation"} 1 ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The two flags --incompatible_remove_native_http_archive and --incompatible_remove_native_git_repository have been enabled by default in a recent release and were subsequently removed, so specifying them in Bazel 0.23.0 will result in an error due to the flags being unknown.
We can just remove them from the .bazelrc now.