add token-vendor resources to helm chart values#672
Conversation
Signed-off-by: Teo Koon Peng <koonpeng@google.com>
Signed-off-by: Teo Koon Peng <koonpeng@google.com>
There was a problem hiding this comment.
I think you need to undo this? Reducing the lockFileVersion seems like a mistake.
There was a problem hiding this comment.
Tried reverting it but doing a bazel build change it back again. Tried checking out main, make sure there are no changes, doing a bazel build still change the lock file version 🤔.
There was a problem hiding this comment.
I think #667 is made with a newer version of bazel that does not respect .bazelversion.
There was a problem hiding this comment.
Hmm, I'm worried about merging the change given https://github.com/googlecloudrobotics/core/pull/667/changes suggests we might break the build elsewhere. Maybe you can just split it out of this commit locally and ignore the fact that Bazel is trying to undo it until @ensonic can let us know if any changes are necessary in the workspace for #667?
Signed-off-by: Teo Koon Peng <koonpeng@google.com>
2 participants
cherry pick from #665.