Skip to content

Port token-vendor ingress to http routes.#673

Merged
ensonic merged 1 commit into
mainfrom
ensonic/istio
May 11, 2026
Merged

Port token-vendor ingress to http routes.#673
ensonic merged 1 commit into
mainfrom
ensonic/istio

Conversation

@ensonic
Copy link
Copy Markdown
Contributor

@ensonic ensonic commented May 11, 2026

Move the configuration of the istio-loadbalancer to the gateway. Now
istio is generating the loadbalancer to match the gateway settings.
This lets us simplify the configuration when updating istio in
third_party.

See #668

@ensonic ensonic marked this pull request as draft May 11, 2026 10:46
@ensonic ensonic requested a review from Tobias-Pe May 11, 2026 10:46
@Tobias-Pe
Copy link
Copy Markdown

How will we add the gateway resource ?
Or is this added by default istio ? Or do u add it urself in your dev env for now

@ensonic ensonic force-pushed the ensonic/istio branch 3 times, most recently from 6992345 to 6914d51 Compare May 11, 2026 13:38
Move the configuration of the istio-loadbalancer to the gateway. Now
istio is generating the loadbalancer to match the gateway settings.
This lets us simplify the configuration when updating istio in
third_party.

See #668
@ensonic ensonic marked this pull request as ready for review May 11, 2026 13:40
Copy link
Copy Markdown

@Tobias-Pe Tobias-Pe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marvelous!!!

@ensonic
Copy link
Copy Markdown
Contributor Author

ensonic commented May 11, 2026

How will we add the gateway resource ? Or is this added by default istio ? Or do u add it urself in your dev env for now

The gateway resource is always manaully added. Its in istio.yaml

@ensonic ensonic merged commit 6698bda into main May 11, 2026
7 checks passed
@ensonic ensonic deleted the ensonic/istio branch May 11, 2026 13:50
@ensonic ensonic changed the title W.I.P.: Port token-vendor ingress to http routes. Port token-vendor ingress to http routes. May 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants