-
Notifications
You must be signed in to change notification settings - Fork 100
Embeddable code labs! #16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- turns off most styling when <google-codelab theme="minimal"> is used
|
This is brilliant! Also, I have a feeling this might break codelabs.developers.google.com, need to try it out on staging. |
|
Tests should be g2g now. Sorry about that. Added the TOC time remaining later on and didnt realize the tests were relying on We should definitely test on staging, but it should be transparent to the live site. If you run demo/codelab.html, it intentionally looks exactly as it did before :) |
|
Ah yes. Our shell page will need to load the fonts at the top of the page. On Sun, Jan 31, 2016, 5:51 AM alex notifications@github.com wrote:
|
|
This is amazing, thanks. |
|
LGTM! 🌟 The tests still fail but I'll be tracking it in #17, unrelated to this. |


R: @crhym3 @aliafshar
Fixes #13. We now support
<google-codelab theme="minimal" no-toolbar no-arrows no-highlight>to create an "embeddable" version of the codelab element.By default, uses of
<google-codelab>get our awesome defaults:However, users have asked for an embeddable version to use in existing doc pages. This PR addresses that, giving users of the elements more control over what parts of the UI show. Adding the
theme="minimal"attribute also neutralizes most of our default styling. An embedding page would use this:The embed.html demo shows this in action by using devsite's actual stylesheet:
We can make further customization hooks if needed.