This repository was archived by the owner on Dec 16, 2025. It is now read-only.
Using Google Feedback when there is no Feedback link provided.#342
Merged
nicolasgarnier merged 5 commits intomasterfrom Sep 4, 2019
Merged
Using Google Feedback when there is no Feedback link provided.#342nicolasgarnier merged 5 commits intomasterfrom
nicolasgarnier merged 5 commits intomasterfrom
Conversation
skarEE
reviewed
Sep 3, 2019
| if (feedbackLink) { | ||
| this.eventHandler_.listen(feedbackLink, events.EventType.CLICK, | ||
| (e) => { | ||
| if (userfeedback && userfeedback.api) { |
Contributor
There was a problem hiding this comment.
if ('userfeedback' in window &&
Contributor
Author
There was a problem hiding this comment.
Added externs
skarEE
approved these changes
Sep 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.