stop filtering _-prefixed anchors during smart component instantiation#2011
Merged
Conversation
The blanket `!a.name.starts_with('_')` filter was a precautionary
heuristic (PR #1885) with no concrete regression behind it. In Glyphs,
`_`-prefixed anchors are the same unified system used for both component
alignment and mark attachment — there is no naming distinction between
the two roles. The mark writer's used_groups intersection already
discards any anchors that don't pair with a counterpart on an exported
glyph, making the filter redundant.
Removing it fixes Padyakke (Kannada), where `_headline` on the smart
component `_part.knmAU` is needed for 277 abvm MarkToBase rules.
With the filter, all `_headline` anchors were dropped and nearly all
Kannada mark attachment was lost.
Verified: `ttx_diff` on Padyakke now reports "output is identical".
Fixes #2010
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2010
JMM