HTML reports & new shaping glue crate#87
Merged
Merged
Conversation
RickyDaMa
force-pushed
the
html-reports
branch
from
1ebe24a to
fbff857
Compare
RickyDaMa
force-pushed
the
html-reports
branch
from
0ad21ea to
4e4d72b
Compare
Add --output and --html to CLI Use maud to put together HTML Extract a bunch of lines from metrics
Write extension traits for harfrust types for better interaction with ShapingMeta Make Location insertion-order preserving (with IndexMap) and reject NaN axis values
Really inefficiently, but baby steps
Add PartialEq, Eq, and PartialOrd to Location
Correctly advance width & height Swap order of pens
Co-authored-by: Harry Dalton <harry.dalton@daltonmaag.com>
Create caches which are re-used (also helps with log flooding) Adjust SVG size to biggest bounds of any word, not biggest metrics Use ordered-float in html.rs
Remove OffsetPen Use groups and more relative co-ordinates Co-authored-by: Jany Belluz <jany.belluz@daltonmaag.com>
Rename BoundsPen::bounding_box to bounds Add BoundsPen::control_bounds Make Location::partial_cmp less unsound Rename utils to convert Remove bogus return values from convert::iso639_to_opentype Change Location::to_harfrust to return an iterator
RickyDaMa
force-pushed
the
html-reports
branch
from
143410e to
eb0ec7b
Compare
RickyDaMa
force-pushed
the
html-reports
branch
2 times, most recently
from
834466e to
f0283ce
Compare
RickyDaMa
force-pushed
the
html-reports
branch
from
f0283ce to
679385d
Compare
Hoolean
reviewed
Oct 31, 2025
| # Make sure CI fails on all warnings, and pretend we're docs.rs | ||
| env: | ||
| RUSTFLAGS: "-Dwarnings -Adead-code -Aunused-imports -Aunused-macros" | ||
| # FIXME: in future, use the below to better match docs.rs. At the time of |
Collaborator
There was a problem hiding this comment.
Ideally, let's move the TODOs and FIXMEs in this file into issues
Collaborator
Author
There was a problem hiding this comment.
Will do after merging!
Hoolean
approved these changes
Oct 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This started as a quest to add visual HTML reports to the CLI, and somehow spawned an entirely new crate.
Basically, shaping details that were buried in private API within
fontheightmade sense to be re-used for the CLI's HTML reports, but didn't make sense (in my opinion) to surface asfontheightAPIs, so I spun out the code intoharfshapedfa, a dedicated glue crate. This has resulted in breaking changes forfontheight.Tracking the API movements by looking at the diffs is going to be very challenging. I'd advise reviewing the code at face value, and review the higher level API movements through the documentation. I've endeavoured to cover everything, and checked with
cargo semver-checks.