[builder] Meaningfully named temporary files#928
Merged
simoncozens merged 2 commits intomainfrom Apr 25, 2024
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The builder uses a lot of temporary files, and when debugging a problem, it's a pain to trace through the
build.ninjafile to determine how/tmp/4p0m9zvx2l739was produced from/tmp/tdpflm38kv4. With this PR, when the builder configlogLevelisDEBUG, files are namedbuilder-<target>-<source>-<steps>. e.g. when you see:you know you are building
PlaywriteAUNSW[wght].ttfand so far you have started withPlaywrite_MM.glyphspackageand run the stepsbuildVariable,fix,buildStatandsubspace.