Document autohintOTF in gfbuilder docs#939
Merged
simoncozens merged 1 commit intogooglefonts:mainfrom May 3, 2024
Merged
Conversation
m4rc1e
pushed a commit
that referenced
this pull request
May 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
autohintTTFis documented, and defaults totrue, so I incorrectly thought that A) OTFs would be auto hinted by default, which I now see is not the case for a reason, and B) that it would be documented if it were an option.This simply documents the option to autohint OTFs, and lets users know it’s off by default.
Writing this, I’m realizing that it probably needs to a be documented in theOh, never mind: I see that the--helpflag of the CLI, too. I’ll try to do that next, and update this PR.--helpflag doesn’t present config options, which makes sense in hindsight.I welcome edits by maintainers – I’m mostly just trying to helpful in pointing this out with a potential patch.