Move GameServer validation to a ValidatingAdmissionWebhook#147
Merged
markmandel merged 1 commit intoagones-dev:masterfrom Mar 17, 2018
Merged
Move GameServer validation to a ValidatingAdmissionWebhook#147markmandel merged 1 commit intoagones-dev:masterfrom
markmandel merged 1 commit intoagones-dev:masterfrom
Conversation
Validation was originally done in a MutationAdmissionWebhook for simplicity, but as we need more validation (for Fleets and supporting CRDs) doing validation work in a Mutation webhook feels like the wrong place to do this work. This also provides *much* better validation errors out of kubectl than the Mutation Webhook provides! ```bash $ kubectl create -f ./examples/cpp-simple/gameserver.yaml The GameServer "" is invalid: * container: Container is required when using multiple containers in the pod template * hostPort: HostPort cannot be specified with a Dynamic PortPolicy * container: Could not find a container named ``` So this configures a validation webhook and moves the validation logic into that code.
markmandel
added
kind/cleanup
Collaborator
|
Build Succeeded 👏 Build Id: 32cbca07-4576-45e6-b923-f30634cf05ef The following development artifacts have been built, and will exist for the next 30 days:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Validation was originally done in a MutationAdmissionWebhook for simplicity, but as we need more validation (for Fleets and supporting CRDs) doing validation work in a Mutation webhook feels like the wrong place to do this work.
This also provides much better validation errors out of kubectl than the Mutation Webhook provides!
So this configures a validation webhook and moves the validation logic into that code.