Shrink main func to resolve gocyclo warning#207
Merged
markmandel merged 1 commit intoagones-dev:masterfrom May 17, 2018
enocom:simple-main
Merged
Shrink main func to resolve gocyclo warning#207markmandel merged 1 commit intoagones-dev:masterfrom enocom:simple-main
markmandel merged 1 commit intoagones-dev:masterfrom
enocom:simple-main
Conversation
Collaborator
|
Build Succeeded 👏 Build Id: 1ba7c0f0-573d-464e-9900-4c25822fd1a9 The following development artifacts have been built, and will exist for the next 30 days:
|
Contributor
Author
|
Rebased onto master for a clean merge. |
Collaborator
|
Build Succeeded 👏 Build Id: 8cee3803-148b-4000-89ee-549b6e0e8279 The following development artifacts have been built, and will exist for the next 30 days:
|
markmandel
approved these changes
May 17, 2018
Collaborator
markmandel
left a comment
markmandel
left a comment
There was a problem hiding this comment.
Approved! Just one question for my own curiosity,
|
|
||
| log.Print("Starting Health Ping") | ||
| stop := make(chan bool) | ||
| stop := make(chan struct{}) |
Collaborator
There was a problem hiding this comment.
Just for my own curiosity - why the change? Because it more closely matches context.Context and some of the Kubernetes constructs?
Contributor
Author
There was a problem hiding this comment.
Since stop is used purely as a signalling mechanism, and not as a way to transport meaningful information, I have followed the Go idiom of using struct{}, which indicates the value is of no meaning in and of itself. On the other hand, bool suggests we might send true or false, when in fact we don't really care about either.
Collaborator
There was a problem hiding this comment.
Thanks! That makes perfect sense!
Collaborator
|
Build Failed 😱 Build Id: 77855fb2-87ff-4b09-873d-05e7247d5690 Build Logs |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #178
This is the simplest fix to the gocyclo linter error: breaking out functions of related code. I propose taking the same approach for #177.