Move cluster node addition/removal out of "experimental"#271
Move cluster node addition/removal out of "experimental"#271markmandel merged 2 commits intoagones-dev:masterfrom
Conversation
Implemented workerqueue for node modifications in the PortAllocator, so that if the master happens to go down, then the operations the PortAllocator has to do to keep things in check will retry and result in a correct state. Closes agones-dev#60
|
Build Succeeded 👏 Build Id: 821d23b9-e497-429d-8413-84eca82f3906 The following development artifacts have been built, and will exist for the next 30 days:
|
enocom
left a comment
enocom
left a comment
There was a problem hiding this comment.
One minor question. Otherwise, this looks good.
| pa.nodeInformer.AddEventHandler(cache.ResourceEventHandlerFuncs{ | ||
| AddFunc: pa.syncAddNode, | ||
| AddFunc: func(obj interface{}) { | ||
| node := obj.(*corev1.Node) |
There was a problem hiding this comment.
I don't know the semantics of the event handler, but is there a chance that obj isn't of *corev1.Node type? In other words, is this a safe type assertion?
There was a problem hiding this comment.
A good question - basically, there isn't really. But a good question!
If something other than a Node comes through a Node event handler, then something very weird has happened -- at which point, it really should panic.
Here another example in the Kubernetes sample-controller doing similar things:
https://github.com/kubernetes/sample-controller/blob/master/controller.go#L129
There was a problem hiding this comment.
Then panicking is exactly the right thing to do.
|
@markmandel If you rebase onto master, I'll be happy to merge. 😄 |
|
Build Succeeded 👏 Build Id: ce29bafc-7668-4e57-bd1c-fb9795a8c526 The following development artifacts have been built, and will exist for the next 30 days:
|
3 participants
Implemented workerqueue for node modifications in the PortAllocator, so that if the master happens to go
down, then the operations the PortAllocator has to do to keep things in check will retry and result in a correct state.
Closes #60