Merged
Conversation
markmandel
added
kind/cleanup
Collaborator
|
Build Failed 😱 Build Id: 29cc6763-6c8b-43ab-9e58-15002735e1d5 Build Logs |
Collaborator
|
Build Failed 😱 Build Id: 7c29fe79-236b-4fdc-8e32-51520d05e50c Build Logs |
Collaborator
|
Build Succeeded 👏 Build Id: b0a3e7d7-2f73-458c-8a07-027cd818f408 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
Collaborator
|
Should we also update our e2e image ? it might cause issue though as the tiller won't match the right version. |
Collaborator
Author
|
OH! is that why it didn't fail? I expected it to fail. Cool - will update the e2e image as well. We'll need to recreate the cluster I expect, but I can manually manage that. |
markmandel
force-pushed
the
feature/helm-update
branch
from
b6c1ac5 to
0c4a918
Compare
Collaborator
|
Build Failed 😱 Build Id: 21e24fd6-dc7d-4795-8b1e-fb28af0f17a7 Build Logs |
Collaborator
Author
|
Cool - this failed as expected now! When this PR get's approval, I'll manage creating the new cluster / upgrading helm by hand before running this again. |
cyriltovena
approved these changes
Oct 26, 2018
Collaborator
cyriltovena
left a comment
cyriltovena
left a comment
There was a problem hiding this comment.
LGTM ! Don't forget to recreate the e2e cluster, I've added a nice target for that.
markmandel
force-pushed
the
feature/helm-update
branch
from
0c4a918 to
c37a3e2
Compare
Collaborator
|
Build Failed 😱 Build Id: 2039f81b-dbb2-4547-8c13-c87b5a0f1316 Build Logs |
markmandel
force-pushed
the
feature/helm-update
branch
from
c37a3e2 to
d8b8c4d
Compare
Collaborator
|
Build Failed 😱 Build Id: 1d79732a-3af2-4aab-957f-cfef34d189b9 Build Logs |
This will likely fail on first PR, as we will need to update the Helm install on the e2e cluster. A good opportunity to delete and restart the e2e cluster anyway -- but will need to manage this around other PRs. Should enable agones-dev#375 to pass tests as well.
markmandel
force-pushed
the
feature/helm-update
branch
from
d8b8c4d to
1e82d6f
Compare
Collaborator
|
Build Succeeded 👏 Build Id: 6fbb6df1-935a-422f-bfed-885267064a3e The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will likely fail on first PR, as we will need to update the Helm install on the e2e cluster.
A good opportunity to delete and restart the e2e cluster anyway -- but will need to manage this around other PRs.
Should enable #375 to pass tests as well.