Finalizer for GameServer until backing Pods are Terminated#40
Merged
markmandel merged 1 commit intomasterfrom Dec 30, 2017
Merged
Finalizer for GameServer until backing Pods are Terminated#40markmandel merged 1 commit intomasterfrom
markmandel merged 1 commit intomasterfrom
Conversation
Because we allocate a port to a GameSever, we cannot delete the GameServer until that port is free again. This means that a GameServer must not be hard deleted until the backing Pod is successfully Terminated - and the port is now free again. This implements a finalizer and backing controller code to manage this. This is work that need to occur for #14 (Dynamic Port Allocation) to be completed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Because we allocate a port to a GameSever, we cannot delete the GameServer until that port is free again.
This means that a GameServer must not be hard deleted until the backing Pod is successfully Terminated - and the port is now free again.
This implements a finalizer and backing controller code to manage this.
This is work that need to occur for #14 (Dynamic Port Allocation) to be completed.