Cluster Autoscaling: safe-to-evict=false annotations for GameServer Pods#405
Merged
markmandel merged 1 commit intoagones-dev:masterfrom Nov 6, 2018
Merged
Conversation
This is the final piece for ensuring that the Kubernetes Autoscaler works with Agones. This ensures that `GameServer` Pods cannot be evicted from the cluster, via annotations that the autoscaler uses to determine that `GameServer` Pods are unsafe to be evicted. This annotation has also been placed on the controller, but can be turned off via Helm chart variables. I expect that cluster autoscaling, and the backing strategies will get tweaked for performance and resource usage as we get more real world experience with it, but this is working relatively nicely right now. Closes agones-dev#368
markmandel
added
kind/feature
Collaborator
|
Build Succeeded 👏 Build Id: 07d27f10-250f-419b-9219-71df196e5210 The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is the final piece for ensuring that the Kubernetes Autoscaler works with Agones.
This ensures that
GameServerPods cannot be evicted from the cluster, via annotations that the autoscaler uses to determine thatGameServerPods are unsafe to be evicted.This annotation has also been placed on the controller, but can be turned off via Helm chart variables.
I expect that cluster autoscaling, and the backing strategies will get tweaked for performance and resource usage as we get more real world experience with it, but this is working relatively nicely right now.
Closes #368