More stringent linting rules (and update linter)#417
Merged
markmandel merged 1 commit intoagones-dev:masterfrom Nov 15, 2018
Merged
More stringent linting rules (and update linter)#417markmandel merged 1 commit intoagones-dev:masterfrom
markmandel merged 1 commit intoagones-dev:masterfrom
Conversation
I noticed that the linter was allowing through some commenting rules that weren't very good, so removed the option that was allowing that to happen `exclude-use-default`, and then also updated the linter while I was in here to the latest version.
Collaborator
|
Build Succeeded 👏 Build Id: a2058a25-2786-4980-80cf-c00c98ee1a5d The following development artifacts have been built, and will exist for the next 30 days:
(experimental) To install this version:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that the linter was allowing through some commenting rules that weren't very good, so removed the option that was allowing that to happen
exclude-use-default, and then also updated the linter while I was in here to the latest version.