Update GameServerSet scheduling when Fleet scheduling is changed. by pooneh-m · Pull Request #582 · agones-dev/agones

pooneh-m · 2019-02-11T17:19:30Z

Fixing issue #495

agones-bot · 2019-02-11T17:29:29Z

Build Succeeded 👏

Build Id: 5dd65dfe-26e3-4520-883e-2e5f7a16e62d

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.8.0-770a734
image: gcr.io/agones-images/agones-sdk:0.8.0-770a734
image: gcr.io/agones-images/agones-ping:0.8.0-770a734
Linux C++ SDK (build: dev): agonessdk-0.8.0-770a734-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.8.0-770a734-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.8.0-770a734-src.zip
SDK Server: agonessdk-server-0.8.0-770a734.zip

A preview of the website (the last 30 builds are retained):

https://770a734-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/582/head:pr_582 && git checkout pr_582
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-770a734

jkowalski · 2019-02-11T17:32:42Z

very nice, can you also add e2e test?

agones-bot · 2019-02-12T22:18:03Z

Build Failed 😱

Build Id: 02bfd7e7-4017-4182-8c94-025a44c259b6

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-02-12T22:23:01Z

Build Succeeded 👏

Build Id: b6355aa5-7127-4ea3-b862-375378cee81d

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.8.0-7edc9d3
image: gcr.io/agones-images/agones-sdk:0.8.0-7edc9d3
image: gcr.io/agones-images/agones-ping:0.8.0-7edc9d3
Linux C++ SDK (build: dev): agonessdk-0.8.0-7edc9d3-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.8.0-7edc9d3-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.8.0-7edc9d3-src.zip
SDK Server: agonessdk-server-0.8.0-7edc9d3.zip

A preview of the website (the last 30 builds are retained):

https://7edc9d3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/582/head:pr_582 && git checkout pr_582
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-7edc9d3

agones-bot · 2019-02-12T22:38:50Z

Build Succeeded 👏

Build Id: 7984a22b-7cfc-4819-aedf-cb9f12d73761

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.8.0-84c0a08
image: gcr.io/agones-images/agones-sdk:0.8.0-84c0a08
image: gcr.io/agones-images/agones-ping:0.8.0-84c0a08
Linux C++ SDK (build: dev): agonessdk-0.8.0-84c0a08-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.8.0-84c0a08-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.8.0-84c0a08-src.zip
SDK Server: agonessdk-server-0.8.0-84c0a08.zip

A preview of the website (the last 30 builds are retained):

https://84c0a08-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/582/head:pr_582 && git checkout pr_582
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-84c0a08

pooneh-m · 2019-02-12T22:46:57Z

very nice, can you also add e2e test?

Done! :)

agones-bot · 2019-02-13T05:26:18Z

Build Succeeded 👏

Build Id: 5b7ad804-470d-47f0-a751-1f8483b6f5bb

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.8.0-67c0faf
image: gcr.io/agones-images/agones-sdk:0.8.0-67c0faf
image: gcr.io/agones-images/agones-ping:0.8.0-67c0faf
Linux C++ SDK (build: dev): agonessdk-0.8.0-67c0faf-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.8.0-67c0faf-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.8.0-67c0faf-src.zip
SDK Server: agonessdk-server-0.8.0-67c0faf.zip

A preview of the website (the last 30 builds are retained):

https://67c0faf-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/582/head:pr_582 && git checkout pr_582
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-67c0faf

agones-bot · 2019-02-13T05:29:17Z

Build Succeeded 👏

Build Id: b04b992d-c17a-4934-858e-19d3de424130

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.8.0-9aabf2a
image: gcr.io/agones-images/agones-sdk:0.8.0-9aabf2a
image: gcr.io/agones-images/agones-ping:0.8.0-9aabf2a
Linux C++ SDK (build: dev): agonessdk-0.8.0-9aabf2a-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.8.0-9aabf2a-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.8.0-9aabf2a-src.zip
SDK Server: agonessdk-server-0.8.0-9aabf2a.zip

A preview of the website (the last 30 builds are retained):

https://9aabf2a-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/582/head:pr_582 && git checkout pr_582
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-9aabf2a

RazvyBD

Hi everyone

markmandel · 2019-02-14T03:08:33Z

This is technically a bug, and could be merged during feature freeze, but I'm thinking we leave this until next release, just to give the current code some time to be tested by our users.

Happy to take dissenting opinions.

test/e2e/framework/framework.go

markmandel

🍰

agones-bot · 2019-02-21T02:12:42Z

Build Succeeded 👏

Build Id: cf36dab4-5aff-4879-9650-c658bf35080a

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.8.0-b0825b3
image: gcr.io/agones-images/agones-sdk:0.8.0-b0825b3
image: gcr.io/agones-images/agones-ping:0.8.0-b0825b3
Linux C++ SDK (build: dev): agonessdk-0.8.0-b0825b3-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.8.0-b0825b3-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.8.0-b0825b3-src.zip
SDK Server: agonessdk-server-0.8.0-b0825b3.zip

A preview of the website (the last 30 builds are retained):

https://b0825b3-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/582/head:pr_582 && git checkout pr_582
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.8.0-b0825b3

agones-bot · 2019-02-21T02:38:03Z

Build Succeeded 👏

Build Id: aca283c4-4a5a-47d3-a2cd-568621c1344c

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.9.0-9b93a78
image: gcr.io/agones-images/agones-sdk:0.9.0-9b93a78
image: gcr.io/agones-images/agones-ping:0.9.0-9b93a78
Linux C++ SDK (build: dev): agonessdk-0.9.0-9b93a78-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.9.0-9b93a78-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.9.0-9b93a78-src.zip
SDK Server: agonessdk-server-0.9.0-9b93a78.zip

A preview of the website (the last 30 builds are retained):

https://9b93a78-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/582/head:pr_582 && git checkout pr_582
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-9b93a78

markmandel added kind/bug These are bugs. area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc labels Feb 12, 2019

pooneh-m force-pushed the dev branch 2 times, most recently from 7edc9d3 to 24b32af Compare February 12, 2019 22:12

pooneh-m force-pushed the dev branch from 24b32af to 84c0a08 Compare February 12, 2019 22:28

pooneh-m force-pushed the dev branch from 67c0faf to 9aabf2a Compare February 13, 2019 05:17

markmandel added the feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) label Feb 13, 2019

RazvyBD reviewed Feb 13, 2019

View reviewed changes

aLekSer reviewed Feb 20, 2019

View reviewed changes

test/e2e/framework/framework.go Outdated Show resolved Hide resolved

markmandel removed feature-freeze-do-not-merge Only eligible to be merged once we are out of feature freeze (next full release) labels Feb 21, 2019

Update GameServerSet scheduling when Fleet scheduling is changed.

b0825b3

pooneh-m force-pushed the dev branch from 9aabf2a to b0825b3 Compare February 21, 2019 02:03

markmandel approved these changes Feb 21, 2019

View reviewed changes

markmandel added this to the 0.9.0 milestone Feb 21, 2019

Merge branch 'master' into dev

9b93a78

markmandel merged commit 861771b into agones-dev:master Feb 21, 2019

markmandel mentioned this pull request Feb 21, 2019

If you modify the Scheduling on a Fleet, it does not flow down to the GameServerSet. #495

Closed

Conversation

pooneh-m commented Feb 11, 2019

Uh oh!

agones-bot commented Feb 11, 2019

Uh oh!

jkowalski commented Feb 11, 2019

Uh oh!

agones-bot commented Feb 12, 2019

Uh oh!

agones-bot commented Feb 12, 2019

Uh oh!

agones-bot commented Feb 12, 2019

Uh oh!

pooneh-m commented Feb 12, 2019

Uh oh!

agones-bot commented Feb 13, 2019

Uh oh!

agones-bot commented Feb 13, 2019

Uh oh!

RazvyBD left a comment

Choose a reason for hiding this comment

Uh oh!

markmandel commented Feb 14, 2019

Uh oh!

Uh oh!

markmandel left a comment

Choose a reason for hiding this comment

Uh oh!

agones-bot commented Feb 21, 2019

Uh oh!

agones-bot commented Feb 21, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants