Develop and Build on Windows (WSL) with Minikube#59
Conversation
This implements several things: - An OS detection and include system for the `build/Makefile` - Removal of the option to build directly on Minikube. This was just too much complexity, especially across platform, and essentially wasn't really needed. - Documentation of how developing on Windows works. Closes #47
|
@Kuqd and @dzlier-gcp - you may find this PR interesting 😁 |
|
I'll give a try |
|
Everything is working fine. This will greatly help once merged. I had issue with proxy but find my way around by modifying a bit the makefile. (not sure it's worth adding) I also found a way to not enforce the bind mount and keep working on /mnt/c or /mnt/[a-z] by adding this in your windows.mk I'm rewriting path and include /mnt/ in your win_to_wsl_path. Good job ! |
|
Awesome - glad it worked for you! Removing the need for the bindmount would be nice (but it would be great it it worked with both with and without!) I was going to suggest that I merge what I have now, and you submit a separate PR with your changes - so we can test with and without the bindmount, and adjust the documentation accordingly. I have a feeling that what you have above will fail if the agon cluster hasn't been created yet (I'm not in front of my Windows PC at the moment, so can't test) Unless you feel strongly that working without bindmount is very important for this PR? |
|
sure go ahead and merge ! |
This implements several things:
build/Makefilejust too much complexity, especially across platform, and
essentially wasn't really needed.
Closes #47