Unified logging of resource identifiers so that we can reliably get entire history of a resource in stack driver. by jkowalski · Pull Request #616 · agones-dev/agones

jkowalski · 2019-02-21T22:32:51Z

Well-known identifiers of resources types are defined in new logfields package.

agones-bot · 2019-02-21T22:37:06Z

Build Failed 😱

Build Id: 4a8eab40-a840-4ab3-a542-1269c28a4af3

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

agones-bot · 2019-02-21T22:49:40Z

Build Succeeded 👏

Build Id: 8e14a0a7-b085-48c8-93f9-2d87f41d453e

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.9.0-4d4c46c
image: gcr.io/agones-images/agones-sdk:0.9.0-4d4c46c
image: gcr.io/agones-images/agones-ping:0.9.0-4d4c46c
Linux C++ SDK (build: dev): agonessdk-0.9.0-4d4c46c-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.9.0-4d4c46c-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.9.0-4d4c46c-src.zip
SDK Server: agonessdk-server-0.9.0-4d4c46c.zip

A preview of the website (the last 30 builds are retained):

https://4d4c46c-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/616/head:pr_616 && git checkout pr_616
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-4d4c46c

markmandel

Overall - awesome. Had a few questions, and a couple of small cleanup items.

markmandel · 2019-02-22T02:17:06Z

pkg/gameserverallocations/controller.go

 	err := json.Unmarshal(obj.Raw, gsa)
 	if err != nil {
-		c.logger.WithError(err).Error("error unmarchaslling json")
+		c.baseLogger.WithError(err).Error("error unmarchalling json")


Suggested change

c.baseLogger.WithError(err).Error("error unmarchalling json")

c.baseLogger.WithError(err).Error("error unmarshalling json")

markmandel · 2019-02-22T02:23:08Z

pkg/gameservers/health.go

 	"strings"

+	"agones.dev/agones/pkg/util/logfields"
+


nit: delete line

markmandel · 2019-02-22T02:24:17Z

pkg/gameserversets/controller.go

 }

+func loggerForGameServerSetKey(base *logrus.Entry, key string) *logrus.Entry {
+	return base.WithField(gameServerSetKeyFieldName, key)


Should this not use logfields.GameServerSetKey ?

markmandel · 2019-02-22T02:24:37Z

pkg/sdkserver/sdkserver.go

 	"time"

+	"agones.dev/agones/pkg/util/logfields"
+


nit: empty line

pkg/util/workerqueue/workerqueue.go

pkg/fleetautoscalers/controller.go

pkg/gameservers/controller.go

…n entire history of a resource in stack driver. Well-known identifiers of resources types are defined in logfields package.

agones-bot · 2019-02-22T22:39:25Z

Build Succeeded 👏

Build Id: 21b80715-7cab-4184-8cb7-272f68fcc057

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.9.0-0cff425
image: gcr.io/agones-images/agones-sdk:0.9.0-0cff425
image: gcr.io/agones-images/agones-ping:0.9.0-0cff425
Linux C++ SDK (build: dev): agonessdk-0.9.0-0cff425-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.9.0-0cff425-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.9.0-0cff425-src.zip
SDK Server: agonessdk-server-0.9.0-0cff425.zip

A preview of the website (the last 30 builds are retained):

https://0cff425-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/616/head:pr_616 && git checkout pr_616
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-0cff425

agones-bot · 2019-02-22T22:42:28Z

Build Succeeded 👏

Build Id: 544d6b8c-3ce8-4c0f-a7cb-5b71caa9b9dd

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.9.0-31fa9d2
image: gcr.io/agones-images/agones-sdk:0.9.0-31fa9d2
image: gcr.io/agones-images/agones-ping:0.9.0-31fa9d2
Linux C++ SDK (build: dev): agonessdk-0.9.0-31fa9d2-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.9.0-31fa9d2-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.9.0-31fa9d2-src.zip
SDK Server: agonessdk-server-0.9.0-31fa9d2.zip

A preview of the website (the last 30 builds are retained):

https://31fa9d2-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/616/head:pr_616 && git checkout pr_616
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-31fa9d2

markmandel

🔔

agones-bot · 2019-02-25T22:25:49Z

Build Succeeded 👏

Build Id: a9b24bc3-f9f9-41c4-9115-1adc2fcdf298

The following development artifacts have been built, and will exist for the next 30 days:

image: gcr.io/agones-images/agones-controller:0.9.0-b4b6f4b
image: gcr.io/agones-images/agones-sdk:0.9.0-b4b6f4b
image: gcr.io/agones-images/agones-ping:0.9.0-b4b6f4b
Linux C++ SDK (build: dev): agonessdk-0.9.0-b4b6f4b-dev-linux-arch_64.tar.gz
Linux C++ SDK (build: runtime): agonessdk-0.9.0-b4b6f4b-runtime-linux-arch_64.tar.gz
Linux C++ SDK (source): agonessdk-0.9.0-b4b6f4b-src.zip
SDK Server: agonessdk-server-0.9.0-b4b6f4b.zip

A preview of the website (the last 30 builds are retained):

https://b4b6f4b-dot-preview-dot-agones-images.appspot.com/

To install this version:

git fetch https://github.com/GoogleCloudPlatform/agones.git pull/616/head:pr_616 && git checkout pr_616
helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-b4b6f4b

jkowalski force-pushed the gs-logging branch from c447e54 to 4d4c46c Compare February 21, 2019 22:40

markmandel reviewed Feb 22, 2019

View reviewed changes

markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Feb 22, 2019

jkowalski force-pushed the gs-logging branch from 4d4c46c to 0cff425 Compare February 22, 2019 22:28

Unified logging of resource identifiers so that we can reliably get a…

31fa9d2

…n entire history of a resource in stack driver. Well-known identifiers of resources types are defined in logfields package.

jkowalski force-pushed the gs-logging branch from 0cff425 to 31fa9d2 Compare February 22, 2019 22:29

Merge branch 'master' into gs-logging

b4b6f4b

markmandel approved these changes Feb 25, 2019

View reviewed changes

markmandel merged commit cb073a9 into agones-dev:master Feb 25, 2019

markmandel added this to the 0.9.0 milestone Mar 7, 2019

	c.baseLogger.WithError(err).Error("error unmarchalling json")
	c.baseLogger.WithError(err).Error("error unmarshalling json")

Conversation

jkowalski commented Feb 21, 2019

Uh oh!

agones-bot commented Feb 21, 2019

Uh oh!

agones-bot commented Feb 21, 2019

Uh oh!

markmandel left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

agones-bot commented Feb 22, 2019

Uh oh!

agones-bot commented Feb 22, 2019

Uh oh!

markmandel left a comment

Choose a reason for hiding this comment

Uh oh!

agones-bot commented Feb 25, 2019

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants