Skip to content

E2E test for Disabled Health checks.#641

Merged
markmandel merged 2 commits intoagones-dev:masterfrom
markmandel:e2e/health-check
Mar 8, 2019
Merged

E2E test for Disabled Health checks.#641
markmandel merged 2 commits intoagones-dev:masterfrom
markmandel:e2e/health-check

Conversation

@markmandel
Copy link
Collaborator

@markmandel markmandel commented Mar 7, 2019

No description provided.

@markmandel markmandel added the area/tests Unit tests, e2e tests, anything to make sure things don't break label Mar 7, 2019
@markmandel markmandel added this to the 0.9.0 milestone Mar 7, 2019
@agones-bot
Copy link
Collaborator

agones-bot commented Mar 7, 2019

Build Succeeded 👏

Build Id: b00bc9b6-cbb9-4d7a-84d5-630564c400d2

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/641/head:pr_641 && git checkout pr_641
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-7f82b0d

jkowalski
jkowalski reviewed Mar 8, 2019
View reviewed changes
test/e2e/gameserver_test.go
}
defer framework.AgonesClient.StableV1alpha1().GameServers(defaultNs).Delete(readyGs.ObjectMeta.Name, nil) // nolint: errcheck

_, err = e2eframework.PingGameServer("UNHEALTHY", fmt.Sprintf("%s:%d", readyGs.Status.Address,
Copy link
Contributor

@jkowalski jkowalski Mar 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: curious why doesn't PingGameServer just take the gameserver object ? We seem to be always doing this Sprintf which is just ugly

Copy link
Collaborator Author

@markmandel markmandel Mar 8, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I wondered the same thing when i was writing this! That would be a good refactor. I'll make a separate PR.

@agones-bot
Copy link
Collaborator

agones-bot commented Mar 8, 2019

Build Succeeded 👏

Build Id: 599801bf-72b7-4680-9423-e520de3aeab9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/641/head:pr_641 && git checkout pr_641
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.9.0-8f364da

@markmandel markmandel merged commit a625fc9 into agones-dev:master Mar 8, 2019
@markmandel markmandel deleted the e2e/health-check branch March 8, 2019 18:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@jkowalski jkowalski jkowalski approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area/tests Unit tests, e2e tests, anything to make sure things don't break

Projects

None yet

Milestone

0.9.0

Development

Successfully merging this pull request may close these issues.

3 participants

@markmandel @agones-bot @jkowalski