Merge hotfix 0.8.1 back into master#658
Merged
markmandel merged 8 commits intoagones-dev:masterfrom Mar 20, 2019
Merged
Conversation
Setting up a hotfix, as we need to enhance and fix some issues regarding installation and helm install management.
The value of agones.serviceaccount.sdk was not propagated down to the creation of the GameServer Pod, so there actually was no way to edit the service account information without Agones breaking. This is now fixed!
…Agones. This doesn't change the default behavior that is currently documented, and willl only probably be used by automated systems that want to enforce strictness when using specific images.
…ones/LICENSES in each of the images.
…by their licenses.
This is almost identical to all the previously approved PRs for 0.8.1 The only difference is that GameServer.DisableServiceAccount needed to be made public, and get called from the GameServer controller instead.
Collaborator
|
Build Succeeded 👏 Build Id: 008bc1eb-93ed-4cd6-9dd1-d40491bbaa9c The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
cyriltovena
approved these changes
Mar 20, 2019
Collaborator
|
Build Failed 😱 Build Id: ce6f7c64-ca09-4330-a105-ae428eebefa9 To get permission to view the Cloud Build view, join the agones-discuss Google Group. |
Collaborator
|
Build Succeeded 👏 Build Id: 4c30c768-0c8a-4ec1-88d1-d34a77c3dba9 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is almost identical to all the previously approved PRs for 0.8.1
The only difference is that GameServer.DisableServiceAccount needed to be
made public, and get called from the GameServer controller instead.
I've left all the original commits, as I figured it made sense to maintain the history in this instance (although happy to take dissenting opinions).