Merged
Conversation
markmandel
added
kind/cleanup
Keep running into [agones-dev#661](stretchr/testify#661) - Allow assert.Equal on string type alias without panicking on failure So upgrading Testify to solve this.
markmandel
force-pushed
the
upgrade/testify
branch
from
c2090cd to
8f0f399
Compare
Collaborator
|
Build Succeeded 👏 Build Id: 67d6e8c6-11cd-4e3a-ac2c-dd5ab3a8d777 The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
EricFortin
approved these changes
Apr 4, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Keep running into #661 - Allow assert.Equal on string type alias without panicking on failure
So upgrading Testify to solve this.