Skip to content

Remove dependency to util/runtime from APIS package#697

Merged
jkowalski merged 1 commit intoagones-dev:masterfrom
pooneh-m:allocation
Apr 9, 2019
Merged

Remove dependency to util/runtime from APIS package#697
jkowalski merged 1 commit intoagones-dev:masterfrom
pooneh-m:allocation

Conversation

@pooneh-m
Copy link
Contributor

@pooneh-m pooneh-m commented Apr 9, 2019

pkg/apis has an unnecessary dependency to pkg/util/runtime.
Removed the dependency to avoid needing to pull runtime imports just to reference apis package externally.

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: 0408080c-a573-4395-b099-5969052be82e

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f10b8cb9-8a6d-4911-850f-724b4bd76ff9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/697/head:pr_697 && git checkout pr_697
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-e99cd34

2 similar comments
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f10b8cb9-8a6d-4911-850f-724b4bd76ff9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/697/head:pr_697 && git checkout pr_697
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-e99cd34

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: f10b8cb9-8a6d-4911-850f-724b4bd76ff9

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/697/head:pr_697 && git checkout pr_697
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-e99cd34

@jkowalski jkowalski merged commit 5ecb1a3 into agones-dev:master Apr 9, 2019
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label Apr 27, 2019
@markmandel markmandel added this to the 0.10.0 milestone Apr 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Refactoring code, fixing up documentation, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants