Skip to content

Add tests for gameServerCacheEntry in GameServerAllocation controller#754

Merged
markmandel merged 2 commits intoagones-dev:masterfrom
markmandel:cleanup/gsa-controller
May 1, 2019
Merged

Add tests for gameServerCacheEntry in GameServerAllocation controller#754
markmandel merged 2 commits intoagones-dev:masterfrom
markmandel:cleanup/gsa-controller

Conversation

@markmandel
Copy link
Collaborator

This moves the cache into its own file to make things a bit more readable, and also to implement some tests for the struct.

This moves the cache into its own file to make things a bit more
readable, and also to implement some tests for the struct.
@markmandel markmandel added the kind/cleanup Refactoring code, fixing up documentation, etc label May 1, 2019
@markmandel
Copy link
Collaborator Author

/cc @ilkercelikyilmaz please let me know if you see any issues

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 6fe17b85-cdcd-438a-9708-4455ec180e37

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/754/head:pr_754 && git checkout pr_754
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-e6e2a99

Copy link
Collaborator

@cyriltovena cyriltovena left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agones-bot
Copy link
Collaborator

Build Failed 😱

Build Id: c3181411-7714-436a-83f0-89c829563581

To get permission to view the Cloud Build view, join the agones-discuss Google Group.

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 298e70a3-1a89-448f-b041-f14d276e7304

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/754/head:pr_754 && git checkout pr_754
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.10.0-0906f40

@markmandel markmandel merged commit 2b08d46 into agones-dev:master May 1, 2019
@markmandel markmandel deleted the cleanup/gsa-controller branch May 1, 2019 19:46
@ilkercelikyilmaz
Copy link
Contributor

/cc @ilkercelikyilmaz please let me know if you see any issues

Sure. I am going to run a load test and let you know if I see something unexpected

@markmandel
Copy link
Collaborator Author

Sweet - should be all the same - I just moved it to a new file, and added some unit tests. No logic changes.

@markmandel markmandel added this to the 0.10.0 milestone May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

kind/cleanup Refactoring code, fixing up documentation, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants