Skip to content

Fleetautoscaler: Add check to have minReplicas>0 when use percents bufferSize#795

Merged
markmandel merged 2 commits intoagones-dev:masterfrom
aLekSer:fas-avoid-empty-fleets
May 29, 2019
Merged

Fleetautoscaler: Add check to have minReplicas>0 when use percents bufferSize#795
markmandel merged 2 commits intoagones-dev:masterfrom
aLekSer:fas-avoid-empty-fleets

Conversation

@aLekSer
Copy link
Collaborator

@aLekSer aLekSer commented May 28, 2019

When n% is used for bufferSize, Fleet would have 0 Replicas forever if minReplicas set to 0 and no
GameServers were allocated. Currently we are calculating number of
GS in a fleet based on Allocated count.

Fleet would have 0 Replicas forever if minReplicas set to 0 and no
GameServers were allocated. Cause currently we are calculating number of
GS in a fleet based on Allocated count.
@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 4e17e574-8578-4dea-a4a0-8d1e2d3e9986

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/795/head:pr_795 && git checkout pr_795
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-9dc6f30

@markmandel markmandel added area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/cleanup Refactoring code, fixing up documentation, etc labels May 29, 2019
@markmandel markmandel added this to the 0.11.0 milestone May 29, 2019
Copy link
Collaborator

@markmandel markmandel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🔬

@agones-bot
Copy link
Collaborator

Build Succeeded 👏

Build Id: 3aeafb07-59cb-4110-9e17-678899899bcf

The following development artifacts have been built, and will exist for the next 30 days:

A preview of the website (the last 30 builds are retained):

To install this version:

  • git fetch https://github.com/GoogleCloudPlatform/agones.git pull/795/head:pr_795 && git checkout pr_795
  • helm install install/helm/agones --namespace agones-system --name agones --set agones.image.tag=0.11.0-118e063

@markmandel markmandel merged commit ad98509 into agones-dev:master May 29, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/user-experience Pertaining to developers trying to use Agones, e.g. SDK, installation, etc kind/cleanup Refactoring code, fixing up documentation, etc

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants