Conversation
build/Makefile
Outdated
| # Use a hash of the Dockerfile for the tag, so when the Dockerfile changes, | ||
| # it automatically rebuilds | ||
| build_version := $(shell sha256sum $(build_path)/build-image/Dockerfile | head -c 10) | ||
| build_version := $(shell \ |
There was a problem hiding this comment.
I'm wondering if we should just move this section below the os-include section - and then can just specify the os specific build_version in each of the includes, rather than writing complicated shell logic?
There was a problem hiding this comment.
That's a nice idea. Since build_version will be used only for development, I suppose it doesn't hurt to define it per os. Does windows have any trouble with sha256sum?
There was a problem hiding this comment.
On windows we push people towards WSL, so we have a nicer cross-platform dev/build cycle - and since it's backed by Ubuntu, sha256sum is already there! 😄
There was a problem hiding this comment.
Perfect. I'll update the PR shortly.
The BSD version of sed does not support multiple `-e` flags and `sha256sum` is not installed by default. This commit makes minor changes to ensure a macOS user may build agones without any additional effort.
enocom
force-pushed
the
macOS-testing
branch
from
489e61b to
d62fba6
Compare
|
@markmandel This should be good now that it includes the LF line ending work. |
2 participants
In addition to renaming occurrences of OS X to macOS, this commit makes some minor changes to the Makefile to ensure macOS users can build Agones.
Fixes #46.