Remove Go SDK repeat connection attempt#998
Merged
markmandel merged 1 commit intoagones-dev:masterfrom Aug 15, 2019
Merged
Conversation
The Go SDK has a block-until-wait in it already, and we should be testing it. So removing the retry logic on the sdk conformance tests.
markmandel
added
kind/cleanup
Collaborator
Author
|
/cc @aLekSer |
roberthbailey
approved these changes
Aug 15, 2019
Collaborator
|
Build Succeeded 👏 Build Id: 6369f702-becc-4805-8d12-d54c056b686a The following development artifacts have been built, and will exist for the next 30 days:
A preview of the website (the last 30 builds are retained): To install this version:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Go SDK has a block-until-wait in it already, and we should be testing it. So removing the retry logic on the sdk conformance tests.