review comments

Author: bashir2

gcp_variant_transforms/libs/beam_util.py

@@ -29,6 +29,7 @@
 from apache_beam.metrics.metric import MetricsFilter
 
 _METRICS_NAME_SPACE = 'VT_metrics_name_space'
+_COUNTERS = 'counters'
 
 
 class BaseCounter(object):
@@ -69,8 +70,8 @@ def get_counter(self, pipeline_result):
     """
     counter_filter = MetricsFilter().with_name(self._counter_name)
     query_result = pipeline_result.metrics().query(counter_filter)
-    if query_result['counters']:
-      counter = query_result['counters'][0]
+    if query_result[_COUNTERS]:
+      counter = query_result[_COUNTERS][0]
       return counter.committed
     return 0
 
@@ -91,6 +92,6 @@ def log_all_counters(pipeline_result):
   """Logs all counters that belong to _METRICS_NAME_SPACE."""
   counter_filter = MetricsFilter().with_namespace(_METRICS_NAME_SPACE)
   query_result = pipeline_result.metrics().query(counter_filter)
-  if query_result['counters']:
-    for counter in query_result['counters']:
+  if query_result[_COUNTERS]:
+    for counter in query_result[_COUNTERS]:
       logging.info('Counter %s = %d', counter, counter.committed)

gcp_variant_transforms/libs/processed_variant_test.py

@@ -25,6 +25,7 @@
 from gcp_variant_transforms.libs import vcf_header_parser
 
 class CounterMock(beam_util.BaseCounter):
+
   def __init__(self):
     self._count = 0
 
@@ -36,6 +37,7 @@ def get_value(self):
 
 
 class CounterFactoryMock(beam_util.BaseCounterFactory):
+
   def __init__(self):
     self.counter_map = {}  # type: Dict[str, CounterMock]