Fix issues in bq to vcf #448
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Pull Request Test Coverage Report for Build 1599
💛 - Coveralls |
kemp-google
reviewed
Mar 8, 2019
| """ | ||
| blobs_to_be_composed = list(self._bucket.list_blobs(prefix=blob_prefix)) | ||
| logging.info('Total number of blobs is %d.', len(blobs_to_be_composed)) | ||
| if not blobs_to_be_composed: |
There was a problem hiding this comment.
This would have been a good candidate for a separate commit. This is part of the value of keeping your commit messages complete from the start: you can then rebase and push when you have multiple unrelated changes in a single PR.
Contributor
Author
There was a problem hiding this comment.
I see! I will drop this PR and create a new one. :)
| genomic_region_parser.parse_genomic_region('chr'), | ||
| ('chr', 0, genomic_region_parser._DEFAULT_END_POSITION) | ||
| ) | ||
| self.assertEqual( |
There was a problem hiding this comment.
This could be folded into the test above (chr1 -> chrY)
- When parsing the genomic region filter, it should be case sensitive. For instance, chrY:1-1000, should have ref=chrY, rather than ref=chry, Or the SELECT query will return the wrong results. This method is reused by partitioning, in which the matching of the reference should be case insensitive.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issues: 447,446
Tested: unit tests