automate release #451
Merged
automate release #451
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
allieychen
commented
Mar 8, 2019
allieychen
commented
- modify the auto integration tests to cover all tests
- update the cloudbuild_release.yaml to be triggered by TAG. It also tags the image after publish.
modify the auto integration tests to cover all tests update the cloudbuild_release.yaml to be triggered by TAG. It also tags the image after publish.
Pull Request Test Coverage Report for Build 1613
💛 - Coveralls |
kemp-google
approved these changes
Mar 11, 2019
cloudbuild_release.yaml
Outdated
| id: 'tag-image-latest' | ||
|
|
||
| timeout: 150m | ||
| timeout: 10m |
There was a problem hiding this comment.
10 minutes is the default, you can remove this
kemp-google
reviewed
Mar 11, 2019
| - name: 'gcr.io/cloud-builders/docker' | ||
| args: | ||
| - 'push' | ||
| - 'tag' |
There was a problem hiding this comment.
I think you need a final push step, too, actually
Contributor
Author
|
Thanks Aaron! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.