Update docker file #467
Merged
Update docker file #467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
User can use docker run command to run the tool. Update the integration tests to be based on the new image.
Pull Request Test Coverage Report for Build 1662
💛 - Coveralls |
kemp-google
reviewed
Apr 5, 2019
cloudbuild_CI.yaml
Outdated
| args: | ||
| - 'build' | ||
| - '--build-arg' | ||
| - 'IMAGE_TAG=${COMMIT_SHA}' |
There was a problem hiding this comment.
The downside of this is that even our released versions will not use the release tag, they will still use the commit SHA1.
I'm not sure there is a better option, though.
cloudbuild_CI.yaml
Outdated
| # The only reason that we use the built image in the 'name' argument is | ||
| # convenience, i.e., to avoid installing python, virtualenv, etc. on the | ||
| # image. | ||
| # Run the test script from the very image we built and pushed. |
There was a problem hiding this comment.
I don't know that this comment adds any value?
cloudbuild_CI.yaml
Outdated
| - '--run_all_tests' | ||
| - '--test_name_prefix cloud-ci-' | ||
| id: 'test-gcp-variant-transforms-docker' | ||
| entrypoint: './deploy_and_run_tests.sh' |
There was a problem hiding this comment.
The ./ gives me pause. I'd usually expect to see either the bare script (to allow exec to do PATH lookup) or a full path.
It's not clear to me why this works (eg, this suggests the working directory inside the container contains the script)
docker/Dockerfile
Outdated
| FROM google/cloud-sdk | ||
|
|
||
| ARG IMAGE_TAG | ||
| ENV image_tag=${IMAGE_TAG} |
There was a problem hiding this comment.
I think, given that it's the COMMIT_SHA we should call it that. Otherwise users that run
docker run gcr.io/gcp-variant-transforms/gcp-variant-transforms:1.0 echo $image_tag
will see a commit SHA1 instead of the tag they actually pulled...
| _PIPELINE_NAME = 'gcp-variant-transforms-bq-to-vcf-integration-test' | ||
| _TEST_FOLDER = 'gcp_variant_transforms/testing/integration/bq_to_vcf_tests' | ||
| _SCRIPT_PATH = '/opt/gcp_variant_transforms/bin/bq_to_vcf' | ||
| _SCRIPT_PATH = 'bq_to_vcf' |
kemp-google
approved these changes
Apr 5, 2019
allieychen
added a commit
to allieychen/gcp-variant-transforms
that referenced
this pull request
Apr 9, 2019
* Update docker file: User can use docker run command to run the tool. Update the integration tests to be based on the new image.
allieychen
added a commit
to allieychen/gcp-variant-transforms
that referenced
this pull request
Apr 9, 2019
* Update docker file: User can use docker run command to run the tool. Update the integration tests to be based on the new image.
allieychen
added a commit
to allieychen/gcp-variant-transforms
that referenced
this pull request
Apr 9, 2019
* Update docker file: User can use docker run command to run the tool. Update the integration tests to be based on the new image.
allieychen
added a commit
to allieychen/gcp-variant-transforms
that referenced
this pull request
Apr 9, 2019
* Update docker file: User can use docker run command to run the tool. Update the integration tests to be based on the new image.
allieychen
added a commit
to allieychen/gcp-variant-transforms
that referenced
this pull request
Apr 9, 2019
* Update docker file: User can use docker run command to run the tool. Update the integration tests to be based on the new image.
allieychen
added a commit
to allieychen/gcp-variant-transforms
that referenced
this pull request
Apr 9, 2019
* Update docker file: User can use docker run command to run the tool. Update the integration tests to be based on the new image.
allieychen
added a commit
to allieychen/gcp-variant-transforms
that referenced
this pull request
Apr 9, 2019
* Update docker file: User can use docker run command to run the tool. Update the integration tests to be based on the new image.
allieychen
added a commit
to allieychen/gcp-variant-transforms
that referenced
this pull request
Apr 9, 2019
* Update docker file: User can use docker run command to run the tool. Update the integration tests to be based on the new image.
allieychen
added a commit
to allieychen/gcp-variant-transforms
that referenced
this pull request
Apr 9, 2019
* Update docker file: User can use docker run command to run the tool. Update the integration tests to be based on the new image.
allieychen
added a commit
to allieychen/gcp-variant-transforms
that referenced
this pull request
Apr 9, 2019
* Update docker file: User can use docker run command to run the tool. Update the integration tests to be based on the new image.
allieychen
added a commit
to allieychen/gcp-variant-transforms
that referenced
this pull request
Apr 9, 2019
* Update docker file: User can use docker run command to run the tool. Update the integration tests to be based on the new image.
allieychen
added a commit
to allieychen/gcp-variant-transforms
that referenced
this pull request
Apr 9, 2019
* Update docker file: User can use docker run command to run the tool. Update the integration tests to be based on the new image.
allieychen
added a commit
to allieychen/gcp-variant-transforms
that referenced
this pull request
Apr 9, 2019
* Update docker file: User can use docker run command to run the tool. Update the integration tests to be based on the new image.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
User can use docker run command to run the tool.
Update the integration tests to be based on the new image.
Tested: integration tests.