Skip to content

Conversation

@arostamianfar
Copy link
Contributor

No description provided.

bashir2
bashir2 previously approved these changes Jan 25, 2018
Copy link
Member

@bashir2 bashir2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great; nice and simple :-)

script:
- ./run_presubmit.sh
after_success:
- coveralls
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: I suppose this is the call that uploads the coverage results to coveralls.io, right? Maybe add a comment for this unless it is obvious for anyone knowing coveralls.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done. PTAL :)

Copy link
Member

@bashir2 bashir2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@arostamianfar arostamianfar merged commit eab423e into googlegenomics:master Jan 25, 2018
@arostamianfar arostamianfar deleted the cov branch February 13, 2018 20:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants