feat(data): add support for parsing GroundOverlay with LatLonQuad bounds - #1739
Merged
Conversation
- Reimplement KML <LatLonQuad> GroundOverlay parsing and mapping on the Kotlin data layer (KmlModel.kt and KmlMapper.kt). - Support corner coordinate arrays (<coordinates>SW SE NE NW</coordinates>), computing the rectified bounding box and average rotation using spherical bearing calculations from SphericalUtil. - Add regression tests in GroundOverlayTest and KmlMapperTest that fail on unpatched code and pass with LatLonQuad support. - Add sample LatLonQuad overlay to ground_overlay.kml and update RendererVisualTest to visually verify both overlays side-by-side on-device.
Contributor
Code Coverage
|
LoyalAbbas
approved these changes
Aug 5, 2026
dkhawk
added a commit
that referenced
this pull request
Aug 5, 2026
- Sync with latest origin/main containing PR #1740 (Gradle 9.6.1 / CI fixes), PR #1739 (LatLonQuad GroundOverlays), PR #1730 (clustering updateItem fix), and PR #1741 (XML serialization hardening). - Preserve all backwards-compatible @deprecated com.google.maps.android.ktx typealiases and forwarding bridges for 6.0.0-rc01. - Add play-services-location and mockito-kotlin dependencies to libs.versions.toml for KTX location module tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reimplements KML
<LatLonQuad>GroundOverlay parsing and mapping on the Kotlin data layer (KmlModel.ktandKmlMapper.kt).Summary of Changes
<coordinates>SW SE NE NW</coordinates>), computing the rectified bounding box and average rotation using spherical bearing calculations fromSphericalUtil.GroundOverlayTestandKmlMapperTestthat fail on unpatched code and pass with LatLonQuad support.ground_overlay.kmland updatesRendererVisualTestto visually verify both Mount Etna overlays side-by-side on-device.Replaces and closes #1396.