NullPointerException on removing item from ClusterManager with NonHierarchicalDistanceBasedAlgorithm when there are more than 1000 items.

[jackie-d]

Summary:

NullPointerException on removing item from ClusterManager with NonHierarchicalDistanceBasedAlgorithm when there are more than 1000 items.

Steps to reproduce:

Add 1000 items.
Remove 1 item.

Expected behavior:

Remove the item.

Observed behavior:

Crash. NPE.

Device and Android version:

Android L,M.

Screenshots:

  E/UncaughtException: java.lang.NullPointerException: Attempt to invoke interface method 'boolean java.util.List.remove(java.lang.Object)' on a null object reference
        at com.google.maps.android.quadtree.PointQuadTree.remove(PointQuadTree.java:176)
        at com.google.maps.android.quadtree.PointQuadTree.remove(PointQuadTree.java:171)
        at com.google.maps.android.quadtree.PointQuadTree.remove(PointQuadTree.java:153)
        at com.google.maps.android.clustering.algo.NonHierarchicalDistanceBasedAlgorithm.removeItem(NonHierarchicalDistanceBasedAlgorithm.java:95)
        at com.google.maps.android.clustering.algo.PreCachingAlgorithmDecorator.removeItem(PreCachingAlgorithmDecorator.java:61)
        at com.google.maps.android.clustering.ClusterManager.removeItem(ClusterManager.java:161)
        at com.giacomodeglinnocenti.myApp.controllers.MapClusterManager.removeItem(MapClusterManager.java:72)

**It is possible this is a duplicate of #308 ? In case I see that the guy there fixed the issue via PR.. But maybe the code has not been added to maven? **

I'm using the following dependency:

compile 'com.google.maps.android:android-maps-utils:0.4.+'

[barbeau]

@giacomodeglinnocenti Yes, I believe this is a duplicate of #308, which has been fixed in the master branch. This fix hasn't been released yet, but I'll go ahead and close this as the problem has been resolved.

@stephenmcd would you be able to cut a new release from the master branch?

[jackie-d]

Ok, thank you @barbeau , I hope you or @stephenmcd will release soon!

[stephenmcd]

We're almost ready to merge a large refactor of KML/GeoJSON internals, probably some time over the next week or so. Once that's done we'll be pushing a new release.

[jackie-d]

Ok, thank you @stephenmcd . I'll wait for that.

[natansalda]

Hello, it seems I have very similar issue currently, but on addItem(). I get this error:

java.lang.NullPointerException: Attempt to invoke virtual method 'int java.lang.String.hashCode()' on a null object reference
        at pl.mytest.app.data.point.dto.AcceptancePoint.hashCode(Unknown Source:55)
        at com.google.maps.android.clustering.algo.NonHierarchicalDistanceBasedAlgorithm$QuadItem.hashCode(NonHierarchicalDistanceBasedAlgorithm.java:297)
        at java.util.HashMap.hash(HashMap.java:338)
        at java.util.HashMap.put(HashMap.java:611)
        at java.util.HashSet.add(HashSet.java:219)
        at com.google.maps.android.clustering.algo.NonHierarchicalDistanceBasedAlgorithm.addItem(NonHierarchicalDistanceBasedAlgorithm.java:75)
        at com.google.maps.android.clustering.algo.PreCachingAlgorithmDecorator.addItem(PreCachingAlgorithmDecorator.java:48)
        at com.google.maps.android.clustering.algo.ScreenBasedAlgorithmAdapter.addItem(ScreenBasedAlgorithmAdapter.java:41)
        at com.google.maps.android.clustering.ClusterManager.addItem(ClusterManager.java:200)

I am using:
'com.google.maps.android:android-maps-utils:2.2.5' (also bumped up to 2.2.6 but no difference)

My OkHhttp call returns more that 1000 items. Could you please guide me how to resolve that?

[barbeau]

@natansalda Could you open a new issue for this? It looks like a different issue - looking at the stack trace it seems like the null reference is in AcceptancePoint.hashCode(), which would be the class in your project that implements ClusterItem. If you could provide the source code for that it would help.