Skip to content

Conversation

@googlemaps-bot
Copy link
Contributor

Updated GitHub pages with latest from ./gradlew dokkaHtml.

@googlemaps-bot googlemaps-bot force-pushed the googlemaps-bot/update_gh_pages branch 2 times, most recently from 8cd1983 to bf1f457 Compare November 5, 2024 00:02
@googlemaps-bot googlemaps-bot force-pushed the googlemaps-bot/update_gh_pages branch from bf1f457 to 59069c0 Compare November 26, 2024 17:09
@googlemaps-bot googlemaps-bot added the automerge Merge the pull request once unit tests and other checks pass. label Nov 26, 2024
@kikoso
Copy link
Collaborator

kikoso commented Dec 3, 2024

@dkhawk , this fails because the header-check is triggering on the HTML files being generated.

Would we really need them to have a copyright note? We could remove this from the header-checker-lint.yml

@dkhawk
Copy link
Contributor

dkhawk commented Dec 3, 2024

@dkhawk , this fails because the header-check is triggering on the HTML files being generated.

Would we really need them to have a copyright note? We could remove this from the header-checker-lint.yml

Yeah. Let's just exclude the generated docs from the check. Unless there is a way to add a header to the generated docs? Either is fine.

@kikoso
Copy link
Collaborator

kikoso commented Dec 4, 2024

Checking if this PR fixes it: #1431

It would add the license headers to all the files in the repo.

@googlemaps-bot googlemaps-bot force-pushed the googlemaps-bot/update_gh_pages branch from 59069c0 to 708b554 Compare December 6, 2024 17:25
@googlemaps-bot googlemaps-bot force-pushed the googlemaps-bot/update_gh_pages branch from 708b554 to 19a89fa Compare December 6, 2024 17:27
@dkhawk dkhawk merged commit cc04cd8 into gh-pages Dec 6, 2024
3 checks passed
@dkhawk dkhawk deleted the googlemaps-bot/update_gh_pages branch December 6, 2024 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge Merge the pull request once unit tests and other checks pass. docs

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants