fix: add @Keep annotation to AttributionIdInitializer#1661
Merged
Conversation
Contributor
Code Coverage
|
dkhawk
added a commit
that referenced
this pull request
Mar 11, 2026
dkhawk
added a commit
that referenced
this pull request
Mar 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
chore: add @keep annotation to AttributionIdInitializer
Purpose:
Adds the
@Keepannotation to theAttributionIdInitializerclass to ensure it is not stripped or obfuscated by R8/ProGuard during release builds.Reasoning:
AttributionIdInitializerimplementsandroidx.startup.Initializerand is declared in theAndroidManifest.xml. Because it is instantiated via reflection by the App Startup library, R8 cannot statically track its usage. Without the@Keepannotation, the class could be removed or renamed in production, preventing the Maps SDK attribution ID from being correctly initialized.Validation:
com.google.maps.android.utils.attribution.AttributionIdInitializerappears inseeds.txtafter a:demo:assembleReleasebuild.