Skip to content

fix: disable XML external entities in KML parser #1673

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dkhawk merged 1 commit into from
Apr 15, 2026
Merged

fix: disable XML external entities in KML parser #1673

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions library/src/main/java/com/google/maps/android/data/kml/KmlLayer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,6 +198,8 @@ private static KmlParser parseKml(InputStream stream) throws XmlPullParserExcept
*/
private static XmlPullParser createXmlParser(InputStream stream) throws XmlPullParserException {
XmlPullParserFactory factory = XmlPullParserFactory.newInstance();
factory.setFeature(XmlPullParser.FEATURE_PROCESS_DOCDECL, false);
factory.setFeature(XmlPullParser.FEATURE_VALIDATION, false);
factory.setNamespaceAware(true);
XmlPullParser parser = factory.newPullParser();
parser.setInput(stream, null);
Expand Down
2 changes: 2 additions & 0 deletions library/src/test/java/com/google/maps/android/data/kml/KmlTestUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,8 @@ public class KmlTestUtil {
static XmlPullParser createParser(String fileName) throws XmlPullParserException, IOException {
InputStream stream = KmlTestUtil.class.getClassLoader().getResourceAsStream(fileName);
XmlPullParserFactory factory = XmlPullParserFactory.newInstance();
factory.setFeature(XmlPullParser.FEATURE_PROCESS_DOCDECL, false);
factory.setFeature(XmlPullParser.FEATURE_VALIDATION, false);
factory.setNamespaceAware(true);
XmlPullParser parser = factory.newPullParser();
parser.setInput(stream, null);
Expand Down
Loading