Skip to content

Equals for Cluster subclasses#169

Closed
hypest wants to merge 3 commits into
googlemaps:masterfrom
fieldaware:equals-for-cluster-subclasses
Closed

Equals for Cluster subclasses#169
hypest wants to merge 3 commits into
googlemaps:masterfrom
fieldaware:equals-for-cluster-subclasses

Conversation

@hypest
Copy link
Copy Markdown
Contributor

@hypest hypest commented Jun 4, 2015

Adds implementations of "equals()" and "hashCode()" in StaticCluster and QuadItem classes. Benefit is the ability to reliably compare (and identify) instances of those classes.

As a bonus (and an implicit way to test QuadItem::hashCode() without exposing the inner class) this PR also includes an implementation of NonHierarchicalDistanceBasedAlgorithm::removeItem(). By the way, this would effectively fix issue #133.

PR commits include relevant tests. Let me know if more testing should be added.

Also, the added test files are new and thus copyrighted after myself, but still under the Apache v2 license. Let me know if this needs to be revised somehow.

Cheers!

@googlebot
Copy link
Copy Markdown

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project, in which case you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed, please reply here (e.g. I signed it!) and we'll verify. Thanks.


  • If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
  • If you signed the CLA as a corporation, please let us know the company's name.

@hypest hypest force-pushed the equals-for-cluster-subclasses branch from 4fb5a43 to f49f604 Compare June 8, 2015 07:51
@hypest
Copy link
Copy Markdown
Contributor Author

hypest commented Jun 8, 2015

I signed it!

@googlebot
Copy link
Copy Markdown

CLAs look good, thanks!

@markmcd
Copy link
Copy Markdown
Contributor

markmcd commented Feb 19, 2016

Code looks good - thanks for taking the time to write tests, too.

With the copyright headers, can you please change the (c) line to Copyright 2015 Google Inc.? You are more than welcome to add yourself to the CONTRIBUTORS.md file (but you don't have to if you don't want to).

@markmcd markmcd self-assigned this Feb 19, 2016
@hypest
Copy link
Copy Markdown
Contributor Author

hypest commented Feb 19, 2016

Thanks for reviewing @markmcd!

More than happy to make the changes! Thing is, I no longer have commit access to this fork so I can't commit the changes. For that, I opened a new PR (#245).

Let me know if there's anything more I should do with the current PR.

Thanks in advance!

@markmcd
Copy link
Copy Markdown
Contributor

markmcd commented Feb 21, 2016

Dropping in favour of #245.

@markmcd markmcd closed this Feb 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants