Increasing ADB timeout to stabalise builds#251
Merged
Conversation
Collaborator
|
For reference, here's the AOSP issue that's supposedly now fixed that allows us to increase the timeout: |
Contributor
|
LGTM |
1 similar comment
|
LGTM |
markmcd
added a commit
that referenced
this pull request
Feb 26, 2016
Increasing ADB timeout to stabalise builds
| } | ||
|
|
||
| // This enables long timeouts required on slow environments, e.g. Travis | ||
| adbOptions { |
Collaborator
There was a problem hiding this comment.
FWIW, I don't think this is actually needed, as I believe Travis & Gradle pick up the ABD timeout from the ADB_INSTALL_TIMEOUT environmental variable defined in .travis.yml. So bumping Gradle plugin alone may be enough to prevent timeouts. I don't think it hurts to have both, although I'm not sure which value wins, this timeout value or the ADB_INSTALL_TIMEOUT.
There was a problem hiding this comment.
I checked with sample project. In the above case the timeout value mentioned in gradle wins over ADB_INSTALL_TIMEOUT.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PTAL @jfschmakeit @domesticmouse @barbeau
Tests look fine but I'm very slightly concerned with using an unstable version of the gradle plugin. We can always revert this if we have to but I am thoroughly sick of restarting travis builds every goddamn day, so think it's worth the risk.