Skip to content

Config for JitPack.io#479

Merged
stephenmcd merged 1 commit into
googlemaps:masterfrom
ipcjs:dev1
Oct 2, 2018
Merged

Config for JitPack.io#479
stephenmcd merged 1 commit into
googlemaps:masterfrom
ipcjs:dev1

Conversation

@ipcjs
Copy link
Copy Markdown
Contributor

@ipcjs ipcjs commented Oct 2, 2018

Make the project can be automatically compiled on jitpack.io by judging whether there is a JITPACK variable.

@stephenmcd
Copy link
Copy Markdown
Contributor

@domesticmouse any thoughts?

@stephenmcd
Copy link
Copy Markdown
Contributor

@ipcjs can you describe what this achieves?

Comment thread library/build.gradle
}
}
}
if (System.getenv("JITPACK")) {
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ipcjs
Copy link
Copy Markdown
Contributor Author

ipcjs commented Oct 2, 2018

@stephenmcd I updated this description.

@barbeau
Copy link
Copy Markdown
Collaborator

barbeau commented Oct 2, 2018

My understanding is that JitPack serves as a "maven central" for projects compiled directly from GitHub commits/releases.

@ipcjs in this projects case, I think the main benefit of enabling JitPack is that it would allow users of the library to use any branch or commit as their dependency. So users could use the current master branch head commit as a direct dependency for their project from JitPack, without having to depend on a release or build the project locally themselves. Is this right? Are there other benefits?

@ipcjs
Copy link
Copy Markdown
Contributor Author

ipcjs commented Oct 2, 2018

@barbeau Yes, you are right, that is all.

@stephenmcd
Copy link
Copy Markdown
Contributor

Ok that seems very worthwhile - thanks all for the input.

@stephenmcd stephenmcd merged commit 851d891 into googlemaps:master Oct 2, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants