Fix compiler and lint warnings#53
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
I'm not convinced this adds very much :)
I think we should at least set the size to 4.
Could you also indent the lines above with spaces instead of tabs?
Contributor
Author
|
I updated |
Contributor
Author
|
Yes, agree that |
Contributor
|
Thank you for all of your contributions! I forgot to ask - have you signed the Google CLA? |
Contributor
Author
|
I submitted the request, but haven't received any confirmation (if there is any) |
Contributor
|
I don't think there's a confirmation - so, thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As discussed in #52, I fixed the compiler and build warnings.
Most commits are straight-forward. The changes to
PointQuadTreeandPolyUtilare covered by unit tests.Notes:
Pointis intentional, so I suppressed the warningPlease have a look, thanks.