Skip to content

Conversation

@dkati
Copy link
Contributor

@dkati dkati commented Mar 16, 2021

If the KML contains <outline>0</outline> the parser still believes there is a border on each polygon

before the commit:
321

after the commit:
123

the KML
222

Fixes #826

@google-cla
Copy link

google-cla bot commented Mar 16, 2021

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@google-cla google-cla bot added the cla: no This human has *not* signed the Contributor License Agreement. label Mar 16, 2021
@dkati
Copy link
Contributor Author

dkati commented Mar 16, 2021

@googlebot I signed it!

@google-cla google-cla bot added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Mar 16, 2021
@dkati dkati changed the title KmlStyle: Correctly parse outline when its declared but value is zero KmlStyle: Fix parsing outline tag when its declared but value is '0' #826 Mar 16, 2021
@dkati dkati changed the title KmlStyle: Fix parsing outline tag when its declared but value is '0' #826 Fix #826 - KmlStyle: Fix parsing outline tag when its declared but value is '0' Mar 16, 2021
@dkati
Copy link
Contributor Author

dkati commented Mar 20, 2021

@arriolac any update here?

@dkati
Copy link
Contributor Author

dkati commented Mar 20, 2021

@arriolac Chris. check this out. i dont know what Semantic bot says :P

@arriolac arriolac changed the title Fix #826 - KmlStyle: Fix parsing outline tag when its declared but value is '0' fix(KmlStyle): Fix parsing outline tag when its declared but value is '0' Mar 22, 2021
Copy link
Contributor

@arriolac arriolac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR!

@arriolac
Copy link
Contributor

@arriolac Chris. check this out. i dont know what Semantic bot says :P

Semantic bot checks that the PR title matches the expected commit convention. I updated your PR title so it does.

@arriolac arriolac merged commit 816aac0 into googlemaps:master Mar 22, 2021
googlemaps-bot pushed a commit that referenced this pull request Mar 22, 2021
## [2.2.1](v2.2.0...v2.2.1) (2021-03-22)

### Bug Fixes

* **KmlStyle:** Correctly parse outline when its declared but value is zero ([#825](#825)) ([816aac0](816aac0))
@googlemaps-bot
Copy link
Contributor

🎉 This PR is included in version 2.2.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. released

Projects

None yet

Development

Successfully merging this pull request may close these issues.

KMLParser cant recognize outline value if its zero

3 participants