-
Notifications
You must be signed in to change notification settings - Fork 1.5k
fix(KmlStyle): Fix parsing outline tag when its declared but value is '0' #825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here with What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
|
@googlebot I signed it! |
|
@arriolac any update here? |
|
@arriolac Chris. check this out. i dont know what Semantic bot says :P |
arriolac
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR!
Semantic bot checks that the PR title matches the expected commit convention. I updated your PR title so it does. |
## [2.2.1](v2.2.0...v2.2.1) (2021-03-22) ### Bug Fixes * **KmlStyle:** Correctly parse outline when its declared but value is zero ([#825](#825)) ([816aac0](816aac0))
|
🎉 This PR is included in version 2.2.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
If the KML contains
<outline>0</outline>the parser still believes there is a border on each polygonbefore the commit:

after the commit:

the KML

Fixes #826