fix: Change project configuration logic #894
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is Option 2 to fix #800 as mentioned in #800 (comment).
The following still needs to be done to restore all previous functionality (I've commented these with
FIXMEin the code, along with the current errors that exist when syncing with Android Studio):Option 1 is presented in PR #895.
@arriolac What are your thoughts on this vs. Option 1?
It's not immediately clear to me how to fix the above issues if we decide to go this route, so any feedback on these would be welcome.
Only one of these two PRs should be merged.
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
BREAKING CHANGEfooter so when this change is integrated a major version update is triggered. See: https://www.conventionalcommits.org/en/v1.0.0/Fixes #800 🦕