Skip to content

Conversation

@barbeau
Copy link
Collaborator

@barbeau barbeau commented Jun 15, 2021

This is Option 2 to fix #800 as mentioned in #800 (comment).

The following still needs to be done to restore all previous functionality (I've commented these with FIXME in the code, along with the current errors that exist when syncing with Android Studio):

  • Fix jacoco-android
  • Fix signAarPublication

Option 1 is presented in PR #895.

@arriolac What are your thoughts on this vs. Option 1?

It's not immediately clear to me how to fix the above issues if we decide to go this route, so any feedback on these would be welcome.

Only one of these two PRs should be merged.


Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Will this cause breaking changes to existing Java or Kotlin integrations? If so, ensure the commit has a BREAKING CHANGE footer so when this change is integrated a major version update is triggered. See: https://www.conventionalcommits.org/en/v1.0.0/

Fixes #800 🦕

@barbeau barbeau added the needs work This is a pull request that needs a little love. label Jun 15, 2021
@barbeau barbeau requested a review from arriolac June 15, 2021 19:34
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 15, 2021
@barbeau barbeau mentioned this pull request Jun 15, 2021
5 tasks
@barbeau
Copy link
Collaborator Author

barbeau commented Jun 16, 2021

Closing this in favor of #895, per comments in #895 (review)

@barbeau barbeau closed this Jun 16, 2021
@barbeau barbeau deleted the sean/fix-agp-4.1.0 branch August 12, 2021 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. needs work This is a pull request that needs a little love.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Build fails with Android Gradle Plugin 4.1.0

1 participant