feat: Sort JSON fields, and show JSON default mostly collapsed#224
Merged
regeter merged 1 commit intogooglemaps:mainfrom Mar 14, 2025
Merged
feat: Sort JSON fields, and show JSON default mostly collapsed#224regeter merged 1 commit intogooglemaps:mainfrom
regeter merged 1 commit intogooglemaps:mainfrom
Conversation
bshi
reviewed
Mar 14, 2025
| export function parseJsonContent(content) { | ||
| log("Parsing JSON content"); | ||
|
|
||
| const sortObjectKeys = (obj) => { |
There was a problem hiding this comment.
Is this used to modify inputs to ReactJson in the change above? Doesn't ReactJson have a mode/option to sort keys built-in?
Contributor
Author
There was a problem hiding this comment.
It's used when ingesting the raw logs and storing them in indexedDB. ReactJson does have a sorted param, but it would have to do this sorting on each dataset switch. I also like that it's now sorted when exporting the logs.
bshi
approved these changes
Mar 14, 2025
Contributor
|
🎉 This PR is included in version 1.12.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Small Quality of Life change.
Easier to compare some data over multiple rows without adding the value to the table. Makes the page look less crowded by default.