Skip to content

feat: add overlay tappable for geometry renderder #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
arriolac merged 2 commits into from
Jul 16, 2021
Merged

feat: add overlay tappable for geometry renderder #376

arriolac merged 2 commits into from
Jul 16, 2021

Conversation

@rxng8
Copy link
Contributor

@rxng8 rxng8 commented Jul 2, 2021 •
edited
Loading

Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open a GitHub issue as a bug/feature request before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (not necessary)

Fixes #375 🦕

I have tried and tested the tappable geometry rendered.

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Jul 2, 2021
@arriolac
Copy link
Contributor

arriolac commented Jul 9, 2021

Thanks for the PR. Can you update this so that all geometries and not just polygons and polylines are tappable?

@rxng8
Copy link
Contributor Author

rxng8 commented Jul 10, 2021

@arriolac Hi, I have added them! Thanks

@arriolac
Copy link
Contributor

arriolac commented Jul 12, 2021

Thanks, @rxng8. One last edit before we can merge your change—please fix the failing Semantic Pull Request check. You can prefix your PR and commit message with "feat: " which should pass the check.

@rxng8 rxng8 changed the title add overlay tappable for geometry renderder feat: add overlay tappable for geometry renderder Jul 16, 2021
@rxng8
Copy link
Contributor Author

rxng8 commented Jul 16, 2021

@arriolac Done! Thanks!

@arriolac arriolac merged commit acff497 into googlemaps:main Jul 16, 2021
googlemaps-bot pushed a commit that referenced this pull request Jul 16, 2021
@semantic-release-bot
chore(release): 3.10.0 [skip ci]
ad7bffa 
# [3.10.0](v3.9.0...v3.10.0) (2021-07-16)

### Features

* add overlay tappable for geometry renderder ([#376](#376)) ([acff497](acff497))
@zabojad zabojad mentioned this pull request Mar 1, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@arriolac arriolac

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Geometry renderer tappable

2 participants

@rxng8 @arriolac