Skip to content

feat: add support for experience id.#647

Merged
arriolac merged 7 commits intomasterfrom
feat/experience_id
Jan 21, 2020
Merged

feat: add support for experience id.#647
arriolac merged 7 commits intomasterfrom
feat/experience_id

Conversation

@arriolac
Copy link
Copy Markdown
Contributor

@arriolac arriolac commented Jan 15, 2020

Closes #643

@arriolac arriolac requested a review from jpoehnelt January 15, 2020 23:24
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jan 15, 2020
@coveralls
Copy link
Copy Markdown

coveralls commented Jan 15, 2020

Coverage Status

Coverage decreased (-0.1%) to 73.893% when pulling 5301430 on feat/experience_id into 6500947 on master.

@arriolac arriolac changed the title feat: add support for experience id feat: add support for experience id. Closes #643 Jan 16, 2020
@arriolac arriolac changed the title feat: add support for experience id. Closes #643 feat: add support for experience id. Jan 16, 2020
Copy link
Copy Markdown
Contributor

@jpoehnelt jpoehnelt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! I did not check why the one travis run failed.

@arriolac
Copy link
Copy Markdown
Contributor Author

Looks like rerunning the Travis job that failed eventually passed. Unclear why that's so finicky.

@arriolac arriolac merged commit b229806 into master Jan 21, 2020
@arriolac arriolac deleted the feat/experience_id branch January 21, 2020 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support Experience Id Header

4 participants