Introducing Geocoded Waypoints into Directions API result.#118
Introducing Geocoded Waypoints into Directions API result.#118samthor merged 9 commits intogooglemaps:masterfrom domesticmouse:master
Conversation
I had to break API backward compatibility with this API, as we were previously returning an array. Bad life choices.
|
PTAL @markmcd |
There was a problem hiding this comment.
DirectionsApi.getDirections(...) is a nice shorthand that lets a user jump straight to the data, compared with newRequest(..) that let's them tweak more things.
Can you restrict the break to just DirectionsApi.newRequest(..) instead? e.g. by introducing a FullDirectionsApiRequest subclass?
There's likely be some tradeoffs we need to make, so could warrant a quick chat IRL with the team.
There was a problem hiding this comment.
Introducing a full results vs an elided just the routes result was a reasonably light change. WDYT?
|
PTAL @markmcd =) |
|
And @samthor |
|
Looks good! It might be nice to get another pair of eyes over this for sanity's sake, but I wouldn't consider it blocking. |
|
Ping @samthor =) |
There was a problem hiding this comment.
For the full request, use {@link Full...}
There was a problem hiding this comment.
Added commentary to both DirectionsApiRequest.java and FullDirectionsApiRequest.java
|
PTAL @samthor - landed the Directions API simplification. |
|
LGTM |
Introducing Geocoded Waypoints into Directions API result.
3 participants
I had to break API backward compatibility with this PR, as we were previously returning an array.