NPE check for route fares, and a better test for permanently closed.#128
Merged
domesticmouse merged 2 commits intogooglemaps:masterfrom Feb 4, 2016
domesticmouse:master
Merged
NPE check for route fares, and a better test for permanently closed.#128domesticmouse merged 2 commits intogooglemaps:masterfrom domesticmouse:master
domesticmouse merged 2 commits intogooglemaps:masterfrom
domesticmouse:master
Conversation
| for (PlacesSearchResult result: response.results) { | ||
| assertNotNull(result); | ||
| if(result.permanentlyClosed) { | ||
| // test success condition |
Contributor
There was a problem hiding this comment.
Tiny nit: you'd usually test success conditions with an assert statement, e.g. assertTrue(result.permanentlyClosed).
Contributor
Author
There was a problem hiding this comment.
I've had to water the test down from asserting the first returned result for the query is permanently closed, to at least one of the returned result set is permanently closed. Because data.
Contributor
|
|
domesticmouse
added a commit
that referenced
this pull request
Feb 4, 2016
NPE check for route fares, and a better test for permanently closed.
Contributor
|
Ahh I missed the outer loop. Makes sense. On Thu, 4 Feb 2016, 17:53 Brett Morgan notifications@github.com wrote:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PTAL @markmcd